Hello SFB
Yes you are right. I searched "as a profession" in OED and got 27 quotes but none for "as profession". So it must be "What do you do as a profession". Likewise, we may say "What do you do as a business/a calling/an occupation".
I parse "She teaches English as a profession" as "She...