Hi! Do you think the following sentence is correct?

"A magazine for students of English has asked its readers to send in articles about an interesting or unusual experience they have had while they were with other family members."

Do you know a comprehensive comparison of time clauses?

Thanks.
1 2
The quoted sentence is correct.

I'm not sure what your other question is asking
TommyekDo you know a comprehensive comparison of time clauses?
No, and I doubt you can find one. The number of combinations is so large and so dependent on the exact situation being described by each sentence that I think it might be impossible to assemble anything really comprehensive. About all you can do is remember the general principles and imitate the speaking and writing of native speakers.

CJ
Site Hint: Check out our list of pronunciation videos.
It's ungrammatical to use present perfect with specific time reference. Isn't while they were an example of it?
TommyekIt's ungrammatical to use present perfect with specific time reference. Isn't while they were an example of it?
I was afraid you'd ask that. Emotion: smile

You've got the rule right, but the combination is not objectionable here. I suspect that while-clauses don't violate the rule even though when-clauses do. while indicates activity over a period of time, so it's not exactly a specific (point in) time.

CJ
Thank for your help, boys. "imitate the speaking and writing of native speakers." - words of wisdom. Sometimes, it's difficult to do, especially when a teacher demands a complete grammatical correctness from you.
Teachers: We supply a list of EFL job vacancies
Tommyekespecially when a teacher demands a complete grammatical correctness from you
Oops! That's a special case, I suppose. Emotion: smile

CJ
Hi.

The sentence should read as, unusual experience they had while they were with other family members.

Use of past continuous indicates a finished action in the past which is in contrary with concept of present perfect.

So in my opinion, the persent perfect should be changed to past simple to have a correct grammatical structure.

Cheers
hrsaneishould read as, unusual experience they had while they ...
Hmm. That doesn't sound quite right to my ear in the context given. The idea is that it is any experience they may have had at any time from their birth until the present moment, and you need the perfect tense to cover the whole time period.

If I talk about "an experience you had", it individualizes it, as if I know exactly which of your experiences I'm talking about. The writer wouldn't know which experience in the case described by the OP.

CJ
Students: We have free audio pronunciation exercises.
Show more