+1

Hello,

Which of the following sentences is correct?

1. If I were your sister, what would you do?
2. If I were your sister, what would you have done?

Thanks.

+2
Karen15

Hello,
Which of the following sentences is correct?
1. If I were your sister, what would you do? (correct)
2. If I were your sister, what would you have done? (incorrect)
It should be "If I had been your sister, what would you have done?"

+2
Karen15Which of the following sentences is correct?1. If I were your sister, what would you do?2. If I were your sister, what would you have done?

The first is definitely correct. The second doesn't follow the usual sequence of tenses for a typical conditional, but given that we replace the past perfect with the past in so many other cases, I would consider it acceptable as it is completely understandable as it stands — a "mixed" conditional.

CJ

Students: We have free audio pronunciation exercises.
Comments  
tamguatlay
Karen15

Hello,
Which of the following sentences is correct?
1. If I were your sister, what would you do? (correct)
2. If I were your sister, what would you have done? (incorrect)
It should be "If I had been your sister, what would you have done?"

Thank you so much.

I think both are correct while expressing different meanings.

Karen151. If I were your sister, what would you do?

What would you do (now) if I were your sister?

Karen152. If I were your sister, what would you have done?

You could never be their sister; time doesn't change anything. But what would you have done (in the past) if you were their sister?

Teachers: We supply a list of EFL job vacancies

I have a question, dear tamgualtlay.

Kindly take the following case:

What would you have done if I had told the truth last week?

I had the ability to tell you the truth last week, but I didn't do that.

--------------------

tamguatlay"If I had been your sister, what would you have done?"

Question: Did you have the ability to be their sister if given the chance?

I guess it would be acceptable if by 'sister' you meant anybody other than a sibling; for example, a 'blood sister' which is common in some cultures where they take a loyalty oath to be brothers/sisters.

 CalifJim's reply was promoted to an answer.
If I were your sister, what would you do?
Site Hint: Check out our list of pronunciation videos.

"If I was your sister, what would you do?" - Speaking about a future action.

"If I was your sister, what would you have done?" - Speaking about an alternative action that could have been done in the past.